Skip to content

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented Jan 8, 2026

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

This was referenced Jan 8, 2026
Copy link
Member Author

adinauer commented Jan 8, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Features

- Use uv for managing python version ([#5009](https://github.com/getsentry/sentry-java/pull/5009))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against 7f42e1f

Comment on lines +18 to +20
if not os.path.exists(".venv"):
proc.run(("uv", "venv", "--seed"))
proc.run(("uv", "sync", "--frozen", "--quiet"))

This comment was marked as outdated.

@@ -0,0 +1,3 @@
[project]
name = "javasdk"
version = "0.0.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing dependencies in pyproject.toml breaks local development

Medium Severity

The pyproject.toml has no dependencies field, and uv.lock only contains the virtual package. However, requirements.txt lists dependencies like requests that are imported by test/system-test-runner.py. When developers use the new devenv setup (uv sync --frozen), the venv is created without these dependencies, causing ImportError when running the test scripts locally.

Additional Locations (1)

Fix in Cursor Fix in Web

@adinauer
Copy link
Member Author

cursor review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!

Base automatically changed from 01-07-add_ai_rules_files_for_metrics_and_update_feature_flags_rule_ to feat/trace-metrics January 14, 2026 10:48
…batchprocessor_from_sentryclient

feat(metrics): [Trace Metrics 22] Close and flush `MetricsBatchProcessor` from `SentryClient`
@adinauer adinauer merged commit bea07c7 into feat/trace-metrics Jan 14, 2026
54 of 56 checks passed
@adinauer adinauer deleted the 01-08-use_uv_for_managing_python_version branch January 14, 2026 10:52
@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 321.74 ms 403.58 ms 81.84 ms
Size 1.58 MiB 2.20 MiB 635.31 KiB

Baseline results on branch: feat/trace-metrics

Startup times

Revision Plain With Sentry Diff
287445f 310.32 ms 355.22 ms 44.91 ms

App size

Revision Plain With Sentry Diff
287445f 1.58 MiB 2.20 MiB 634.11 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants